This repository has been archived by the owner on Sep 18, 2024. It is now read-only.
Add API to query intermediate results in NAS benchmark #2728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ultmaster
commented
Jul 24, 2020
ultmaster
commented
- Fix nasbench201 api bug #2721
- Add API to return intermediate results
|
What is the reason that caused #2721 ? It seems that if user set include_intermediates=False, this issue still exists. |
JunweiSUN
approved these changes
Jul 27, 2020
QuanluZhang
approved these changes
Jul 30, 2020
QuanluZhang
reviewed
Jul 31, 2020
| @@ -52,8 +53,8 @@ class NdsTrialConfig(Model): | |||
| 'residual_basic', | |||
| 'vanilla', | |||
| ]) | |||
| model_spec = JSONField(index=True) | |||
| cell_spec = JSONField(index=True, null=True) | |||
| model_spec = JSONField(json_dumps=json_dumps, index=True) | |||
There was a problem hiding this comment.
why this modification can resolve the dict element sequence issue?
There was a problem hiding this comment.
The comparison of JSON field is based on string comparison, and to compare two dumped JSON of unordered dict, they need to be sorted ahead.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.